This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
[MRG + 1] Update contributor's guide with new labels #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
vinayak-mehta
changed the title
vinayak-mehta
suggested changes
Oct 2, 2018
vinayak-mehta
changed the title
|
@vinayak-mehta CONTRIBUTING.md is the one file I updated. Is there something else? |
|
I need to update the labels in the docs. Should be done in a minute. |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 65.31% 65.31%
=======================================
Files 12 12
Lines 1231 1231
Branches 292 292
=======================================
Hits 804 804
Misses 389 389
Partials 38 38Continue to review full report at Codecov.
|
Oops, I was referring to the one in the docs. I see that you've updated it. LGTM, merging. |
vinayak-mehta
approved these changes
Oct 2, 2018
vinayak-mehta
changed the title
|
@johnnymetz Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New labels are
help wantedandgood first issue