Chore/upgrade pkg #3632
Merged
Chore/upgrade pkg #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
requested review from
myarichuk,
admons and
julianpellasrice-snyk
PeterSchafer
force-pushed
the
chore/upgrade_pkg_test
branch
6 times, most recently
from
190030b to
3c2e062
Compare
Signed-off-by: Peter Schäfer <[email protected]> chore: upgrade depcheck from 1.4.1 to 1.4.3 … resolves issue of false positive unused dependencies when running `npx ts-node ./scripts/check-dependencies.ts` Signed-off-by: Peter Schäfer <[email protected]> chore: pin pkg to the exact version Signed-off-by: Peter Schäfer <[email protected]> chore: update nodejs 16.14.2 to 16.16.0 Signed-off-by: Peter Schäfer <[email protected]> chore: disable sudo since the new docker node image … … doesn’t support it Signed-off-by: Peter Schäfer <[email protected]> chore: inverse default value of ‘npm_global_sudo’ and adapt usage Signed-off-by: Peter Schäfer <[email protected]> chore: update nodejs versions 14.19.1 to 14.20.0 Signed-off-by: Peter Schäfer <[email protected]> chore: extend jest matrix test Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]> Signed-off-by: Peter Schäfer <[email protected]>
PeterSchafer
force-pushed
the
chore/upgrade_pkg_test
branch
from
3c2e062 to
3f93319
Compare
Avishagp
reviewed
Aug 31, 2022
| @@ -74,7 +74,7 @@ commands: | |||
| default: /mnt/ramdisk/.npm | |||
| npm_global_sudo: | |||
| type: boolean | |||
| default: true | |||
| default: false | |||
There was a problem hiding this comment.
Are these npm changes done due to the failing tests that had no npm installed? did you find out what was the problem?
There was a problem hiding this comment.
Yes. In the image cimg/node:16.16.0 npm is not available with sudo but for the current user. With this I felt it would make sense to change the default behavior here and invert it basically everywhere where it was set to false before.
Avishagp
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrading
pkgfrom 5.6.0 to 5.8.0 to also upgradepkg-fetchfrom 3.3.0 to 3.4.2, this updates the bundled Node runtime from 16.14.2 to 16.16.0, makes these fixes available and addresses CVE-2022-32223, CVE-2022-32212 ...Upgrading
depcheckfrom 1.4.1 to 1.4.3 due to incorrectly detected unused dependencies when runningnpx ts-node ./scripts/check-dependencies.ts