From 7da9c46df7cb689969c69928699e0f6d553de9f7 Mon Sep 17 00:00:00 2001 From: Ankit Bhatnagar Date: Tue, 14 Sep 2021 12:10:32 -0700 Subject: [PATCH 1/2] SNOW-460679 Bump version from 1.2.7 to 1.2.8 --- Snowflake.Data/Snowflake.Data.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Snowflake.Data/Snowflake.Data.csproj b/Snowflake.Data/Snowflake.Data.csproj index f95f5ed81..626c63dae 100755 --- a/Snowflake.Data/Snowflake.Data.csproj +++ b/Snowflake.Data/Snowflake.Data.csproj @@ -12,7 +12,7 @@ Snowflake Connector for .NET howryu, tchen Copyright (c) 2012-2019 Snowflake Computing Inc. All rights reserved. - 1.2.7 + 1.2.8 Full From a09c058b421706efcb7b52dea5b8b697eb20b10a Mon Sep 17 00:00:00 2001 From: sfc-gh-cconner Date: Tue, 14 Sep 2021 14:14:08 -0400 Subject: [PATCH 2/2] Fixed okta authenticator to support format https://vanity.url.com/snowflake/okta (#365) Co-authored-by: Chris Conner --- Snowflake.Data/Core/Authenticator/IAuthenticator.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Snowflake.Data/Core/Authenticator/IAuthenticator.cs b/Snowflake.Data/Core/Authenticator/IAuthenticator.cs index 6a00ebf02..1a057f987 100644 --- a/Snowflake.Data/Core/Authenticator/IAuthenticator.cs +++ b/Snowflake.Data/Core/Authenticator/IAuthenticator.cs @@ -90,14 +90,14 @@ protected void Login() } /// - /// Specialized authenticator data to add to the login request. + /// Specialized authenticator data to add to the login request. /// /// The login request data to update. protected abstract void SetSpecializedAuthenticatorData(ref LoginRequestData data); /// /// Builds a simple login request. Each authenticator will fill the Data part with their - /// specialized information. The common Data attributes are already filled (clientAppId, + /// specialized information. The common Data attributes are already filled (clientAppId, /// ClienAppVersion...). /// /// A login request to send to the server. @@ -181,9 +181,8 @@ internal static IAuthenticator GetAuthenticator(SFSession session) return new OAuthAuthenticator(session); } - // Okta would provide a url of form: https://xxxxxx.okta.com or https://xxxxxx.oktapreview.com - else if ((type.EndsWith("okta.com") || type.EndsWith("oktapreview.com") ) - && type.StartsWith("https://")) + // Okta would provide a url of form: https://xxxxxx.okta.com or https://xxxxxx.oktapreview.com or https://vanity.url/snowflake/okta + else if (type.Contains("okta") && type.StartsWith("https://")) { return new OktaAuthenticator(session, type); }