-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snorkel fails to install for Python 3.8 due to scikit-learn version #1627
Comments
Hi @rjurney, we're taking a look. I haven't been able to repro your issue yet. As a minimal example, on Mac OS X 11.1 with Python 3.7.3, the following commands succeed for me:
|
It looks like Python 3.7 works fine, Python 3.8 hits the Cython import issue. |
scikit-learn versioning is definitely hampering my ability to use snorkel either locally with pipenv and either python 3.7 or 3.8, or remotely google colab. I'll explain: Locally
output:
I can confirm that the virtualenv approach laid out by @bhancock8 above works for 3.7 and not 3.8, but it seems using pipenv does not work in either case. Google ColabGoogle Colab seems to run Python 3.6.9. Here the issue seems to be that snorkel wants to install UMAP which requires scikit-learn>=0.22 while colab installs 0.21.3 by default. At the same time, snorkel 0.9.6 requires scikit-learn<0.22.0. Here's a Colab notebook that runs through this problem |
When I use I have to use the command |
@yongzx this is fixed by bumping the version of scikit-learn to You may need to create a fresh conda, pipenv or virtualenv and then do the install as old components screw things up. I had your issue, bumped the version myself, still had it, nuked my conda env, rebuilt it from scratch with the new snorkel and it works. |
Issue description
When you install Snorkel, it tries to install scikit-learn - which does not build. Thus Snorkel does not build. Can we please update the version of scikit-learn so people can build and use Snorkel?
Code example/repro steps
It tries to install
scikit-learn<0.22.0,>=0.20.2
and fails :(Expected Behavior
I expect the install to succeed. It fails.
System Info
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: