Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire/refresh old Objects #628

Closed
snarfed opened this issue Aug 30, 2023 · 2 comments
Closed

Expire/refresh old Objects #628

snarfed opened this issue Aug 30, 2023 · 2 comments
Labels

Comments

@snarfed
Copy link
Owner

snarfed commented Aug 30, 2023

Would be nice to have a way to specify how long Objects are valid before we need to refresh them. Probably per-protocol, and even may vary with protocols, eg ATProto commits and CID-based objects are permanent, records vary, and did:plc resolution is currently 24-72h ish (bluesky-social/atproto#1535). Also, if refresh fails, we can probably often use our stale stored version, but maybe not always?

@snarfed
Copy link
Owner Author

snarfed commented Feb 7, 2024

Couple options here:

  • Datastore TTL policy, like we already do to expire transient activities like creates, updates, deletes.
  • Age limit in Protocol.load after which we refetch.

Leaning toward the latter so that we preserve older metadata like Object.created.

@snarfed snarfed added the now label Feb 7, 2024
@snarfed snarfed closed this as completed in c966090 Feb 8, 2024
@snarfed
Copy link
Owner Author

snarfed commented Feb 8, 2024

Did the latter. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant