Add Prettier support for editorconfig file #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 25 25
Lines 418 418
Branches 93 79 -14
=======================================
Hits 369 369
- Misses 40 42 +2
+ Partials 9 7 -2
Continue to review full report at Codecov.
|
mrm007
reviewed
Jun 21, 2018
|
|
||
| it('should resolve the prettier config with the editorconfig option', async () => { | ||
| // only mock prettier `resolveConfig` method | ||
| jest.mock('prettier', () => |
There was a problem hiding this comment.
This will get hoisted to the top of the file and might have unintended side-effects for other tests importing Prettier. jest.doMock() is more appropriate for this case.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #125, this change will allow Prettier to parse and use the
.editorconfigfile (if present).