Turn Order needs to be handled how it is in-game

[DanUgore]

Mostly relevant to VGC and Triples. At the moment it is done using a sorting function which compares two pokemon at a time while ordering based on speed.
Properly handling this issue will involve:

• determining turn order before any moves are played out
• sorting the pokemon based on the in-game sort function. this includes using speed & 8191 over speed for comparisons.
• using the battle's rng -- this.random() -- to determine speed-ties

This will also allow us to not require getStatCallback() for the "Trick Room Glitch"

[DanUgore]

Putting this here so I do not forget to work on it later.

[Joimer]

@V4Victini question, was something changed about this?

[DanUgore]

It's partially done. I just need to handle residuals.

[bb010g]

bump

[ascriptmaster]

What was the Trick Room Glitch?

[Slayer95]

https://www.youtube.com/watch?v=TmZHKZJMnBc

[ascriptmaster]

I noticed recently in comparePriority that there's code to check sub-priorities as well. Could we fashion out some sort of ModifySubPriority that Trick Room can use instead of mucking with speed?

[DanUgore]

https://github.com/DanUgore/Pokemon-Showdown/blob/turn-order/battle-engine.js#L3181

Here's an example @ascriptmaster Just have Trick Room modify decision.speed and not decision.pokemon.speed

[ascriptmaster]

That works too. ModifyDecisionSpeed?

[DanUgore]

Sure.

[DanUgore]

Speed is compared...

• Before the turn plays out
• After Mega Evolution (still uses pre-mega evolution speed. its just the order that the mega evolution occurs)
• Before residuals (since mega evolution has already occurred it uses that speed)

Determining who wins a speed tie

• Make a list of tied pokemon in order. Host (P1) Position A (left) would be the start (0), P2/P4 Position C (right) would be the end.
• Roll a number between 0 and tied_pokemon_total - 1. Put that position to go first.
• Repeat Step 2 while decrementing until tied_pokemon_total == 1 and add the final pokemon to the end

[Zarel]

Wait, that's known? Do you have a link?

[Zarel]

Also, what happens in the case of multiple speed ties?

[DanUgore]

I don't have a link. I was talking with Kaphotics about the behavior back when I was working in the issue and needed to know how it worked. Also what do you mean by multiple speed ties? I don't see how that would cause different behavior.

[Zarel]

Depending on how Game Freak implements multiple speed ties, this could work completely differently in that case.