Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "__type" in favor of "name" in Exceptions #96

Closed
trivikr opened this issue Jan 13, 2020 · 0 comments · Fixed by #112
Closed

Remove "__type" in favor of "name" in Exceptions #96

trivikr opened this issue Jan 13, 2020 · 0 comments · Fixed by #112

Comments

@trivikr
Copy link
Contributor

trivikr commented Jan 13, 2020

Is your feature request related to a problem? Please describe.
We now include __type and name on every structure. The 'name' was only being added on exceptions, but that isn't the case. We need to either only add 'name' to exceptions and leave __type how it is, or we need to remove __type altogether.

Describe the solution you'd like
Remove "__type" in favor of "name" in Exceptions

Describe alternatives you've considered
Have redundant value in both "name" and "__type"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant