Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@range on byte, short, integer and long shapes. #1968

Closed
4 tasks done
Tracked by #1401
crisidev opened this issue Nov 9, 2022 · 1 comment · Fixed by #2036
Closed
4 tasks done
Tracked by #1401

@range on byte, short, integer and long shapes. #1968

crisidev opened this issue Nov 9, 2022 · 1 comment · Fixed by #2036
Assignees
@LukeMathWalker
Labels
constraint-traits
Milestone
Server GA

Comments

@crisidev
Copy link
Contributor

crisidev commented Nov 9, 2022 •
edited by david-perez
Loading

Implement the @range trait:
@crisidev crisidev mentioned this issue Nov 9, 2022
Open
23 tasks
@jjant jjant changed the title range on byte, short, integer, long, float, and double shapes. @range on byte, short, integer, long, float, and double shapes. Nov 15, 2022
@LukeMathWalker LukeMathWalker moved this from To do to In progress in Server SDK (Developer preview) Nov 17, 2022
@LukeMathWalker LukeMathWalker self-assigned this Nov 17, 2022
@LukeMathWalker LukeMathWalker moved this from In progress to In Review in Server SDK (Developer preview) Nov 18, 2022
@LukeMathWalker LukeMathWalker linked a pull request Nov 18, 2022 that will close this issue
@range implementation for integer shapes #2005
Merged
1 task
@LukeMathWalker LukeMathWalker removed a link to a pull request Nov 18, 2022
@range implementation for integer shapes #2005
Merged
1 task
@LukeMathWalker LukeMathWalker mentioned this issue Nov 18, 2022
Merged
1 task
@LukeMathWalker LukeMathWalker changed the title @range on byte, short, integer, long, float, and double shapes. @range on byte, short, integer and long shapes. Nov 18, 2022
@LukeMathWalker LukeMathWalker moved this from In Review to In progress in Server SDK (Developer preview) Nov 22, 2022
@LukeMathWalker LukeMathWalker moved this from In progress to In Review in Server SDK (Developer preview) Nov 22, 2022
@spinski spinski added this to the Server GA milestone Nov 24, 2022
@LukeMathWalker LukeMathWalker moved this from In Review to In progress in Server SDK (Developer preview) Nov 28, 2022
@LukeMathWalker
Copy link
Contributor

I've opened a PR to upstream our additional protocol tests for short, integer and long shapes: smithy-lang/smithy#1515

@LukeMathWalker LukeMathWalker mentioned this issue Nov 29, 2022
Merged
1 task
@LukeMathWalker LukeMathWalker moved this from In progress to In Review in Server SDK (Developer preview) Nov 29, 2022
@LukeMathWalker LukeMathWalker moved this from In Review to In progress in Server SDK (Developer preview) Nov 29, 2022
@LukeMathWalker LukeMathWalker mentioned this issue Nov 29, 2022
Merged
1 task
@LukeMathWalker LukeMathWalker moved this from In progress to In Review in Server SDK (Developer preview) Nov 29, 2022
Repository owner moved this from In Review to Done in Server SDK (Developer preview) Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukeMathWalker LukeMathWalker

Labels
constraint-traits
Projects
None yet
Milestone
Server GA
Development

Successfully merging a pull request may close this issue.

Implement @range on long and byte shapes smithy-lang/smithy-rs
3 participants
@crisidev @LukeMathWalker @spinski