Skip to content

Negative result code send instead of IGNORED for UnsubscribedVehicleData when VehicleInfo IsReady Missing #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 9 tasks
DrachenkoAnastasiia opened this issue Nov 7, 2016 · 0 comments
Labels

Comments

@DrachenkoAnastasiia
Copy link

DrachenkoAnastasiia commented Nov 7, 2016

Occurrence

Always

Preconditions

ATF is properly set-up according to note below.
In user_modules>IsReady_Template in test_run folder of ATF build put attached file ATF_Interface_IsReady_missing_SingleRPC_Template.lua.
In test_scripts folder in sdl_atf_test_scripts folder of ATF build put attached file ATF_VehicleInfo_IsReady_missing_SingleRPC_USER_DISALLOWED.lua.

Steps to reproduce

Run script. Check result in section Testing RPC = UnsubscribeVehicleData of test TC_UnsubscribeVehicleData_Only_USER_DISALLOWED_Case_1_IsReady_HMI_Does_Not_Respond (last one in script).

Actual result

  1. DISALLOWED recult code is sent
    SDL->MOB(12:05:00) [version: 2, frameType: 1, encryption: false, serviceType: 7, frameInfo: 0, messageId: 14] :
    {"resultCode":"USER_DISALLOWED","success":false}.

  2. Issue is reproducible for resultCodes * "success":false*.

Expected result

As described in requirement:
<<In case UnubscribeVehicleData request is trying to unsubscribe the parameter the application is not yet subscribed for (even if the request contains at least one subscribed parameter), SDL must:

  1. ignore not subscribed items and transfer subscribed params of UnsubscribeVehicleData to HMI>>

SDL->MOB [version: 2, frameType: 1, encryption: false, serviceType: 7, frameInfo: 0, messageId: 14] :
{"resultCode":"IGNORED","success":false}

Notes:
Current example is for USER_DISALLOWED but this applies for all negative result codes such as ABORTED, etc.
Please find attached sdl and ATF logs.

{code}
To reproduce using ATF need (checked on clean Ubuntu 14.04):
1. clone https://github.com/CustomSDL/sdl_atf_test_scripts/ repository
2. Goto cloned repo, in config.py of specify
sdl_repository = "https://github.com/smartdevicelink/sdl_core/"
sdl_branch = "release/4.2.0"
atf_repository = "https://github.com/smartdevicelink/sdl_atf/"
atf_branch = "962e1eff8664d97af5e59ec4e22f39b9ea76f5eb"
3. sudo apt-get install libexpat1-dev openssh-server libgl1-mesa-dev
4.sudo add-apt-repository ppa:ubuntu-toolchain-r/test
5 ./setup_env.sh
6. fab -H localhost prepare
7. Goto ~/SmartDeviceLinkCore/test_run
8. ./start.sh <path_to_attached_script> --sdl_core SDL_bin/
{code}

Environment

SDL:
Repository: https://github.com/smartdevicelink/sdl_core/
Tag: 4.2.0
commit: a6c32b4
ATF version: 2.2 / 962e1eff8664d97a

Attachments

att_issue#996.zip.

Expected delivery

  • Source code updates 
  • Code comments 
  • UTs add/update 
  • ATF tests add/update (not required) 
  • Manual tests (not required) 
  • Add/update CI plans/jobs (not required) 
  • SDD updates (not required) 
  • Guidelines update (sdl_core_guides(not required) 
  • Guidelines update (sdl_hmi_integration_guidelines) (not required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants