From eafbc88ef5f5fd725773852668750de15333a763 Mon Sep 17 00:00:00 2001 From: Tate Date: Wed, 12 Oct 2022 10:53:56 -0600 Subject: [PATCH] QA-78 Remove usages of deprecated set-output syntax --- .github/workflows/lint.yml | 2 +- .github/workflows/tag.yml | 2 +- .github/workflows/test_asdf_plugin.yml | 16 +++++++++++++++- bin/tool-versions-to-env | 2 +- 4 files changed, 18 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index d07d3b6..8c9971f 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,7 +1,7 @@ name: lint on: - push: + pull_request: jobs: shellcheck: diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml index 3674bc4..58d765b 100644 --- a/.github/workflows/tag.yml +++ b/.github/workflows/tag.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v3 - name: Get the version id: get_version - run: echo ::set-output name=version::${GITHUB_REF/refs\/tags\/v/} + run: echo "version=${GITHUB_REF/refs\/tags\/v/}" >>$GITHUB_OUTPUT - name: copy with version in name run: cp ./bin/tool-versions-to-env ./tool-versions-to-env-${{ steps.get_version.outputs.version }} - name: Release diff --git a/.github/workflows/test_asdf_plugin.yml b/.github/workflows/test_asdf_plugin.yml index ee3d1b1..08b3705 100644 --- a/.github/workflows/test_asdf_plugin.yml +++ b/.github/workflows/test_asdf_plugin.yml @@ -1,6 +1,6 @@ name: test asdf plugin on: - push: + pull_request: jobs: test_asdf_plugin: @@ -24,4 +24,18 @@ jobs: OUTPUT=$(./bin/tool-versions-to-env 3 shfmt_version) if [ "$OUTPUT" -ne "3.4.2" ]; then exit 1 + fi + test_action: + name: Test if action sets outputs + runs-on: ubuntu-latest + steps: + - name: Checkout the Repo + uses: actions/checkout@v3 + - name: get versions + id: versions + uses: ./ + - name: Verify + run: | + if [ "${{ steps.versions.outputs.shellcheck_version }}" != "0.8.0" ]; then + exit 1 fi \ No newline at end of file diff --git a/bin/tool-versions-to-env b/bin/tool-versions-to-env index 2adc226..f5fdbdb 100755 --- a/bin/tool-versions-to-env +++ b/bin/tool-versions-to-env @@ -67,7 +67,7 @@ read_tool_versions_write_to_env() { if [ "$how_to_echo" -eq 1 ]; then echo "${full_key}=${value}" >>"${env_file}" elif [ "$how_to_echo" -eq 2 ]; then - echo "::set-output name=${full_key}::$value" + echo "${full_key}=$value" >>"$GITHUB_OUTPUT" elif [ "$how_to_echo" -eq 3 ]; then echo "$value" break