Support defining classes in multiple JDK versions. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Jul 22, 2020
io/src/main/java9/io/smallrye/common/io/classloader/ClassDefiner.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 22, 2020
dmlloyd
reviewed
Jul 24, 2020
classloader/src/main/java/io/smallrye/common/classloader/ClassDefiner.java
Outdated
Show resolved
Hide resolved
gastaldi
reviewed
Jul 24, 2020
dmlloyd
reviewed
Jul 27, 2020
classloader/src/main/java/io/smallrye/common/classloader/ClassDefiner.java
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 27, 2020
classloader/src/main/java9/io/smallrye/common/classloader/ClassDefiner.java
Show resolved
Hide resolved
radcortez
force-pushed
the
defineClass
branch
2 times, most recently
from
aa5faf8 to
1babfbf
Compare
dmlloyd
reviewed
Jul 27, 2020
dmlloyd
reviewed
Jul 27, 2020
classloader/src/main/java9/io/smallrye/common/classloader/ClassDefiner.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 27, 2020
classloader/src/main/java/io/smallrye/common/classloader/DefineClassPermission.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 28, 2020
classloader/src/main/java/io/smallrye/common/classloader/DefineClassPermission.java
Outdated
Show resolved
Hide resolved
|
One comment, otherwise everything looks OK. |
…eClassPermission.java Co-authored-by: David M. Lloyd <[email protected]>
|
Thanks :) |
dmlloyd
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proposal to start the discussion on how we want to support this. The main motivator is the mapping feature in SmallRye Config:
radcortez/smallrye-config@b5dea58#r40821102