Expression default value with DOUBLE_COLON #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Oct 21, 2022
expression/src/main/java/io/smallrye/common/expression/Expression.java
Outdated
Show resolved
Hide resolved
| @@ -551,4 +551,22 @@ public void testPoint46() { | |||
| assertEquals("", c.getExpandedDefault()); | |||
| }), "Should expand to empty string"); | |||
| } | |||
|
|
|||
| @Test | |||
| void doubleColonFlagAndDefault() { | |||
There was a problem hiding this comment.
Should be testPoint7_5 or whatever to correlate above. Also missing are the following cases:
foo.bar::baz:somethingfoo.bar::baz::somethingfoo.bar:baz::somethingfoo.bar:baz:something
With, and without, DOUBLE_COLON set.
There was a problem hiding this comment.
I was wondering what should foo.bar::baz:something expand to. I think it makes sense that the resulting key is the entire expression since the DOUBLE_COLON flag states that the entire content is encoded into the key, but I can see people expecting to encode only foo.bar::baz in the key and use the default something.
radcortez
force-pushed
the
double-colon
branch
from
064906f to
cc5389f
Compare
dmlloyd
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.