DIR 1 - Remove extrabalance

[LefterisJP]

Changelog

• 23 - 05 - 2016 Issue created
• 13 - 06 - 2016 Turned the issue into a DAO Improvement Request

Problem Description

For the original DAO deployment the notion of an extraBalance account was used in order to keep the extra funds sent to the DAO by potential DAO Token Holders after the lowest price DAO creation phase was over.

This was due to initial requests by the community to provide for variable price on the DAO tokens during the creation period. The existence of the extraBalance and the fact that the DAO needs to spend as much as is in the extraBalance to be able to access it creates a lot of complications both during the creation phase of the DAO and after.

Proposed Solution.

Completely Remove the extraBalance from the code. Here is the PR that provides the implementation for this: #244

[ghost]

What will happen to the balance in the extraBalance account?

[LefterisJP]

@pdulong It will be moved to the DAO's balance.

The DAO will make a proposal to move the balance of the extraBalance account back into the actual DAO balance so that it can use it.

The new contract won't need any extra balance.

[kangaroosterus]

This is labeled as a feature but it I just wanted to point out that DAO.minQuorum(_amount) is currently not being calculated properly because of this.

This is because minQuorum() is a function of the DAO.actualBalance() which does not take into consideration the extraBalance. actualBalance() is a function of the DAO's this.balance so once this extraBalance is moved over the minQuorum() will fix itself.

So in actuality, anywhere actualBalance() is used is currently not 100% accurate.

[LefterisJP]

@cougarously The minQuorum was not supposed to count the balance of the extra balance so there is nothing wrong here.

[kangaroosterus]

@LefterisJP - ok but once extraBalance is removed and the funds in that ManagedAccount is moved to the DAO.balance, minQuorum will start counting it, correct?

[LefterisJP]

In that case yes.

[CJentzsch]

solved in #228

[ghost]

If the extraBalance is moved to the mainBalance, will users be able to withdraw their extraBalance paid or is the exchange ratio, in case of a split, still fixed?

[LefterisJP]

@pdulong no they won't. This was never the intention.

[LefterisJP]

This issue is now formatted as a DIR and is at the draft stage.

[CJentzsch]

done