-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Non PSR7 Methods to Decorator #50
Comments
I'm not adverse to this as long as /cc @danopz |
Sounds like both oppinions doesn't real match. But after thinking a bit about it my oppinion is to just keep the methods as is. The reason is if we would add some decorator class/static helper/whatever we would just add complexity without a real gain. |
Ok, I think an interface of the Slim methods would be beneficial at least; one that extends the Psr interface to aid in type declaration. |
Done. #67 |
I would like to suggest we make a pure PSR7 implementation and move any non-PSR7 methods to a decorator classes labelled something like
SlimRequestDecorator
.Any of the immutable methods should of course clone properly down through the involved classes.
This would allow us to create pure PSR objects if needed, and add functionality like non-PSR methods and our static factory methods and media type parsers within the decorator.
Feedback on this suggestion would be appreciated.
The text was updated successfully, but these errors were encountered: