Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to deactivate SafeEyes for some apps in flatpak #627

Closed
Jopp-gh opened this issue Aug 9, 2024 · 8 comments
Closed

Ability to deactivate SafeEyes for some apps in flatpak #627

Jopp-gh opened this issue Aug 9, 2024 · 8 comments

Comments

@Jopp-gh
Copy link

Jopp-gh commented Aug 9, 2024

Is your plugin request related to a problem? Please describe.
to be honest, I don't know how to use the Do not disturb plugin. If I use wmctrl in bash, single windows come up with all kind of strings. Some explaination how to configure said plugin would be more than welcome. Another point, the Do not disturb plugin works "just" in fullscreen mode which is great but not the solution I'm looking for.

Describe the plugin you'd like
I would like to have a plugin that blocks SafeEyes in some applications, it may send some notification but noting more. Example, if I use a web browser, SafeEyes should be quiet, or when I am in the midst of video editing.

Describe alternatives you've considered
Well, I don't know python but slighly modifying the Do not disturb plugin should be enough.

Additional context

@Jopp-gh Jopp-gh added the plugin label Aug 9, 2024
@archisman-panigrahi archisman-panigrahi changed the title Ability to deactivate SaveEyes for some apps Ability to deactivate SafeEyes for some apps Aug 10, 2024
@archisman-panigrahi
Copy link
Collaborator

We already have this. Open the settings for do not disturb, and enter the name of your browser. I just tested that it works with Firefox
image

@Jopp-gh
Copy link
Author

Jopp-gh commented Aug 31, 2024

Your suggestion seems not working for flatpak apps.

Furthermore, wouldn't be easier to add applications, let's say, via choose dialog instead to try and guess around with app names ?

Could you please research this issue in depth ?

@archisman-panigrahi
Copy link
Collaborator

@Jopp-gh Flatpak apps are isolated from the rest of the system. I doubt if they can detect other apps are running. If you want to use this feature, then please don't use flatpak.

@Jopp-gh
Copy link
Author

Jopp-gh commented Aug 31, 2024

Yes, true. However it's perfectly possible to interact with flatpaks, if you use flatpak run <flatpakID> <cmd>.

You get the flatpak ID in terminal with:
flatpak list

Many of my apps are flatpaks, so it wouldn't be an option for me to switch to a deb package. Also, Flatpaks are the future, imo.

SafeEyes IS great, still the do not disturb plugin doesn't work for all, like for flatpak apps.

@archisman-panigrahi
Copy link
Collaborator

@otuva Can you please look into this? Will adding some persmission to the flatpak enable this feature?

@archisman-panigrahi archisman-panigrahi changed the title Ability to deactivate SafeEyes for some apps Ability to deactivate SafeEyes for some apps in flatpak Aug 31, 2024
@archisman-panigrahi
Copy link
Collaborator

Many of my apps are flatpaks, so it wouldn't be an option for me to switch to a deb package.

@Jopp-gh We are providing .deb packages which do not have this bug, and I am very sure most of your system applications are still deb packages as long as you are using a debian based system.

The flatpak is maintained by the community, and is not officially maintained/supported by us.

If you want to have this feature in flatpak, then you will have to wait for someone to send a patch to the flatpak package/send it yourself.

Also, Flatpaks are the future, imo.

Being isolated, the current implementation of flatpaks are not the best choice for apps which interact a lot with other apps.

@Jopp-gh
Copy link
Author

Jopp-gh commented Aug 31, 2024

Agree to both of your points. Maybe this isn't a bug, but more a compatibility issue.

Linux offers all kind of apps, like snaps, appImage, flatpaks, deb, etc. I don't expect you cover all of them in SafeEyes's plugins, but popular ones like flatpak, should be covered.

Mac and windows in general use only app or exe, sometimes also java or python. Linux instead is another beast.

@archisman-panigrahi
Copy link
Collaborator

but popular ones like flatpak, should be covered.

We already provide native packages for all popular distributions (except RedHat/Fedora, for which we provide a pip package), and this feature works out of the box in all these cases.

It is already covered from our side. There is nothing we can do if it does not work with flatpak due to flatpak's design.
If something works in everywhere except flatpak, then the way flatpak works needs to be fixed, irrespective of how popular flatpak is.

Anyway, we won't be able to fix the flatpak issue by arguing. If anyone knows how to fix this, please send a PR to https://github.com/flathub/io.github.slgobinath.SafeEyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants