Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 272 - error when echo 0 into dirty_background_bytes and dirty_bytes #287

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

przemyslaw-szustak
Copy link
Contributor

When
echo 0 > /proc/sys/vm/dirty_background_bytes
or
echo 0 > /proc/sys/vm/dirty_bytes
failed and return 1 (file was probably locked because it existed and was writable) then woeusb crashed with message 'program is prematurely aborted' but everything works.

@slacka
Copy link
Owner

slacka commented Nov 19, 2019

Looks good. Thanks for the fix!

@slacka slacka merged commit 7434985 into slacka:master Nov 19, 2019
@SpineEyE
Copy link

I'm not sure what this workaround is about, but those commands will actually never run successfully:

# echo 0 > /proc/sys/vm/dirty_bytes
bash: echo: write error: Invalid argument
# echo 0 > /proc/sys/vm/dirty_background_bytes
bash: echo: write error: Invalid argument

See https://www.kernel.org/doc/Documentation/sysctl/vm.txt

@slacka
Copy link
Owner

slacka commented Dec 21, 2019

@SpineEyE
Indeed, these values are read-only on current kernels. However this was originally added to work around a kernel bug. See 0f1d3a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants