add a 'closed' event #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Needs CHANGELOG, tests and a README update please. Maybe call it |
|
Bump, maybe you want to finish this one @rkadyb ? |
|
Sorry for the delay, will finish this one up shortly! |
|
I cleaned this PR up a bit, please let me know what you think. |
|
I like it! Squash it and I'll merge? |
changelog entry updated readme, real_time example add integration test
|
Squashed, thanks! |
|
I merged. Before the next version ships, maybe we want a proper callback mechanism added here where you can do things before, after and around something, ActiveSupport style. Maybe you might want to take a look @rkadyb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up needing an 'after-close' event for a project I'm working on, figured I'd share this in case it's worthwhile for anyone else.
Reasoning:
The existing
:closeevent is fired BEFORE the websocket connection is actually closed, which makes sense if you want to send a message / use the API immediately before disconnect. This isn't as helpful if you want to do something not related to the API AFTER the disconnect.