Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace & remove npm packages #233

Merged
merged 5 commits into from
Sep 11, 2021
Merged

Replace & remove npm packages #233

merged 5 commits into from
Sep 11, 2021

Conversation

dotoleeoak
Copy link
Member

@dotoleeoak dotoleeoak commented Sep 9, 2021

TODO

  • LESS preprocessor 지우기
  • Node Sass => Dart Sass로 대체 (+/deep/ syntax 대체)
  • babel-eslint => @babel/eslint-parser로 대체
  • font-awesome 지우기
  • screenfull 지우기
  • Vue 안 쓰이는 third-party 지우기 (vue-highlight-component, vue-cropper, vue-analytics)

vue-analytics는 deprecated package로, 추후 별도 PR에서 vue-gtag을 이용해 따로 구현 예정입니다.

Closes #184
Closes #185

Deprecated된 문법인 /deep/ syntax를 ::v-deep syntax로 대체

Closes #184, #185
@dotoleeoak dotoleeoak added FE Frontend tasks maintain labels Sep 9, 2021
@dotoleeoak dotoleeoak requested a review from jimin9038 September 9, 2021 07:36
@dotoleeoak dotoleeoak marked this pull request as ready for review September 9, 2021 07:37
@jimin9038
Copy link
Member

마침 vue-analytics 관련해서 찾아보고 있었는데, 좋습니다
근데 지금까지의 analytics는 어떻게 볼 수 있나요?

@dotoleeoak
Copy link
Member Author

dotoleeoak commented Sep 10, 2021

@jimin9038 원래는 google analytics 페이지에서 발급받은 키값을 VueAnalytics 같은 도구에 넣는 방식인데, 기존 코드에 constant로 저장되어 있던 값은 우리가 쓰는 값이 아니라서 새로 받아야됩니다. (즉 지금까지의 analytics는 우리가 못 봅니다)
+ (위에도 언급했지만) 지금은 VueAnalytics가 지원이 되지 않는 패키지라 vue-gtag로 구현 예정입니다.

Copy link
Member

@jimin9038 jimin9038 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다

@dotoleeoak dotoleeoak merged commit 5594a87 into master Sep 11, 2021
@dotoleeoak dotoleeoak deleted the dev/organize-npm-packages branch September 11, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Frontend tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate node-sass to dart-sass /deep/ syntax is deprecated
2 participants