-
Notifications
You must be signed in to change notification settings - Fork 10
Handle nodes that don't have a slot #16
Comments
+1 for approach described in 2 👍 I'm betting this'll be the best approach for transporting / hiding default slot content too. Also, using the placeholder elements, you'd have to tag them based on the slots they were distributed to, then query for them during hydration - would this significantly hurt perf? I'm thinking of hydration performance vs weight of duplicate nodes with the approach described in 1. Would it be worth spiking the second to see perf / complexity issues? |
Yeah, probably. There might be other ways to do this, too. I want to find out for sure if bots will crawl |
Fair enough - once confident in a |
Since we're not sending over the distributed tree anymore, we don't need to do this. |
As Justin points out here, something our lib doesn't handle is undistributed nodes.
I'm trying to think how a search engine would want to see these, if at all. I'm thinking "no" because it's not something the user would see and there's no way to determine composed order. Given that, I think the best thing might be to contain undistributed nodes in a
<template />
or and to put them in as light DOM upon rehydration.One downside to this is that you lose ordering with distributed light DOM. A couple of ways around this might be to:
The text was updated successfully, but these errors were encountered: