Skip to content
This repository has been archived by the owner on Jan 4, 2018. It is now read-only.

Properly rehydrate default slot content #10

Closed
3 tasks
treshugart opened this issue Jul 29, 2017 · 2 comments
Closed
3 tasks

Properly rehydrate default slot content #10

treshugart opened this issue Jul 29, 2017 · 2 comments

Comments

@treshugart
Copy link
Member

treshugart commented Jul 29, 2017

We currently render the entire composed tree for search engines. However, we are only rehydrating shadow roots and their slots. We aren't taking the content composed into slots and moving them back into the host as light DOM if it's composed content (not default content).

  • How are named slots handled?
  • Keep slot content if it's the default content (might need a temporary default flag on the slot.
  • Is there a use case for more than two levels of slots (<slot><slot><slot>...)? If so, need to figure this out.
@bedeoverend
Copy link
Contributor

I'm confused - I thought we were covering rehydration of composed back into light DOM?

So in the nametag example, the rehydrated content has been pulled out of the composed slots and put it back into the light DOM. That addresses point 3 at least (and I think it should still work with point 4 too - i.e. n-nested slots, though haven't tested that) - unless I'm misunderstanding the issues?

@treshugart
Copy link
Member Author

I think I'm the one who was confused. I can't remember exactly why I put that there so I've removed it. For the last one, I just want to test it and if it works, then awesome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants