diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php index 8f1fb270..896a2f9c 100644 --- a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php +++ b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php @@ -48,10 +48,6 @@ class VariableAnalysisSniff implements Sniff { public $validUnusedVariableNames = null; public function register() { - if (!empty($this->validUnusedVariableNames)) { - $this->validUnusedVariableNames = - preg_split('/\s+/', trim($this->validUnusedVariableNames)); - } return [ T_VARIABLE, T_DOUBLE_QUOTED_STRING, @@ -124,7 +120,10 @@ protected function getOrCreateVariableInfo($varName, $currScope) { $scopeInfo = $this->getOrCreateScopeInfo($currScope); if (!isset($scopeInfo->variables[$varName])) { $scopeInfo->variables[$varName] = new VariableInfo($varName); - if ($this->validUnusedVariableNames && in_array($varName, $this->validUnusedVariableNames)) { + $validUnusedVariableNames = (empty($this->validUnusedVariableNames)) + ? [] + : preg_split('/\s+/', trim($this->validUnusedVariableNames)); + if (in_array($varName, $validUnusedVariableNames)) { $scopeInfo->variables[$varName]->ignoreUnused = true; } }