do not overwrite "sams" in "folder_paths" if it is present #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigcat88
added a commit
to Visionatrix/Visionatrix
that referenced
this pull request
Dec 17, 2024
Found why we couldn't do this before: The `comfyui-art-venture` node overwrites the `sams` value of the directory inside ComfyUI and what we specify via the standard legal method using the ]extra_model_paths.yaml] file didn't work. This PR fixes it, until it's merged I just made the same commit to our fork: sipherxyz/comfyui-art-venture#69 Now in new installs `sam_vit_b_01ec64.pth` file will be correctly placed file in the normal "external" directory. Signed-off-by: bigcat88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this small change, this node overwrites the
samsvalue set by theextra_model_paths.yamlconfig, which is not very good.A simple check to see if such an entry exists solves the problem.