feat(all): specify a Feature App's base URL #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
force-pushed
the
base-url
branch
2 times, most recently
from
895eb01 to
6fcccba
Compare
This allows an integrator to specify a relative or absolute `baseUrl`
for two purposes:
1.) as a common base URL for the `src`, `serverSrc`, and `css` hrefs
2.) to provide the Feature App with a base URL that it can use to
reference its own assets and/or BFF
janstoff
reviewed
Apr 16, 2019
clebert
requested changes
Apr 16, 2019
clebert
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an integrator to specify a relative or absolute
baseUrlfor two purposes:1.) as a common base URL for the
src,serverSrc, andcsshrefs2.) to provide the Feature App with a base URL that it can use to reference its own assets and/or BFF