fix(history-service): navigation after reload #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
force-pushed
the
fix-navigation-after-reload
branch
from
2229f09 to
213711b
Compare
clebert
requested changes
Dec 13, 2018
unstubbable
force-pushed
the
fix-navigation-after-reload
branch
4 times, most recently
from
4330bc1 to
a1cdeb0
Compare
unstubbable
force-pushed
the
fix-navigation-after-reload
branch
from
a1cdeb0 to
6d1a8e2
Compare
clebert
requested changes
Dec 17, 2018
unstubbable
force-pushed
the
fix-navigation-after-reload
branch
2 times, most recently
from
1470392 to
b09e473
Compare
clebert
requested changes
Dec 18, 2018
unstubbable
force-pushed
the
fix-navigation-after-reload
branch
from
f53fc29 to
68c9185
Compare
clebert
requested changes
Dec 18, 2018
clebert
previously approved these changes
Dec 19, 2018
Instead of using a memory history under the hood for the consumer history, and storing the entries in session storage, we just compute the consumer path from the root location, and store all consumer states in the root history state. This change also removes the memory history. We don't need a facade for memory histories, since they don't affect the URL and browser history. For server-side rendering we will provide a static history instead (in a separate upcoming PR).
This also moves the destroy method from the base history to the browser history, since the static history won't support the listen method.
This increase is intended and caused by the addition of fast-deep-equal.
unstubbable
force-pushed
the
fix-navigation-after-reload
branch
from
1fe46f0 to
63b1e21
Compare
clebert
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #171
Instead of using a memory history under the hood for the consumer history, and storing the entries in session storage, we just compute the consumer path from the root location, and store all consumer states in the root history state.
This change also removes the memory history. We don't need a facade for memory histories, since they don't affect the window location and browser history. For server-side rendering, we provide a static history instead.