fix(core): clarify error message (#212)

feature-hub · Jan 2, 2019 · e77b70b · e77b70b
1 parent 95e1a2d
commit e77b70b
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 15 deletions.
diff --git a/packages/core/src/__tests__/feature-app-manager.test.ts b/packages/core/src/__tests__/feature-app-manager.test.ts
@@ -144,16 +144,6 @@ describe('FeatureAppManager', () => {
   });
 
   describe('#getFeatureAppScope', () => {
-    it('logs an info message after creation', () => {
-      manager.getFeatureAppScope(mockFeatureAppDefinition, 'testIdSpecifier');
-
-      expect(spyConsoleInfo.mock.calls).toEqual([
-        [
-          'The feature app scope for the ID "testId" and its specifier "testIdSpecifier" has been successfully created.'
-        ]
-      ]);
-    });
-
     it('creates a feature app with a consumer environment using the service registry', () => {
       const mockConfig = {kind: 'test'};
       const idSpecifier = 'testIdSpecifier';
@@ -217,6 +207,16 @@ describe('FeatureAppManager', () => {
 
     describe('for a known feature app definition', () => {
       describe('and no id specifier', () => {
+        it('logs an info message after creation', () => {
+          manager.getFeatureAppScope(mockFeatureAppDefinition);
+
+          expect(spyConsoleInfo.mock.calls).toEqual([
+            [
+              'The feature app scope for the ID "testId" has been successfully created.'
+            ]
+          ]);
+        });
+
         it('returns the same feature app scope', () => {
           const featureAppScope = manager.getFeatureAppScope(
             mockFeatureAppDefinition
@@ -243,6 +243,19 @@ describe('FeatureAppManager', () => {
       });
 
       describe('and an id specifier', () => {
+        it('logs an info message after creation', () => {
+          manager.getFeatureAppScope(
+            mockFeatureAppDefinition,
+            'testIdSpecifier'
+          );
+
+          expect(spyConsoleInfo.mock.calls).toEqual([
+            [
+              'The feature app scope for the ID "testId" with the specifier "testIdSpecifier" has been successfully created.'
+            ]
+          ]);
+        });
+
         it('returns the same feature app scope', () => {
           const featureAppScope = manager.getFeatureAppScope(
             mockFeatureAppDefinition,

diff --git a/packages/core/src/feature-app-manager.ts b/packages/core/src/feature-app-manager.ts
@@ -217,11 +217,15 @@ export class FeatureAppManager implements FeatureAppManagerLike {
     });
 
     console.info(
-      `The feature app scope for the ID ${JSON.stringify(
-        featureAppDefinition.id
-      )} and its specifier ${JSON.stringify(
-        idSpecifier
-      )} has been successfully created.`
+      idSpecifier
+        ? `The feature app scope for the ID ${JSON.stringify(
+            featureAppDefinition.id
+          )} with the specifier ${JSON.stringify(
+            idSpecifier
+          )} has been successfully created.`
+        : `The feature app scope for the ID ${JSON.stringify(
+            featureAppDefinition.id
+          )} has been successfully created.`
     );
 
     let destroyed = false;