fix(react): remove mission critical feature app todos (#297)

We decided that this feature is implementable for the integrator with reasonable effort without changes to the feature-hub/react package.
feature-hub · Jan 24, 2019 · da651bc · da651bc
1 parent 50a883a
commit da651bc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/packages/react/src/feature-app-container.tsx b/packages/react/src/feature-app-container.tsx
@@ -56,7 +56,6 @@ export class FeatureAppContainer extends React.PureComponent<
       console.error(error);
 
       if (!inBrowser) {
-        // TODO: we should only throw for "mission critical" Feature Apps ...
         throw error;
       }
     }

diff --git a/packages/react/src/feature-app-loader.tsx b/packages/react/src/feature-app-loader.tsx
@@ -64,7 +64,6 @@ export class FeatureAppLoader extends React.PureComponent<
       this.reportError(asyncFeatureAppDefinition.error);
 
       if (!inBrowser) {
-        // TODO: we should only throw for "mission critical" Feature Apps ...
         throw asyncFeatureAppDefinition.error;
       }