fix(react): do not set state after FeatureAppContainer has been unmou…

…nted (#613)
feature-hub · Nov 13, 2020 · ba42b6a · ba42b6a
1 parent 3e89e75
commit ba42b6a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/react/src/__tests__/feature-app-container.test.tsx b/packages/react/src/__tests__/feature-app-container.test.tsx
@@ -1090,6 +1090,22 @@ describe('FeatureAppContainer', () => {
           });
         });
       });
+
+      describe('when unmounted before loading promise is resolved', () => {
+        it('does not try to set state', async () => {
+          const testRenderer = renderWithFeatureHubContext(
+            <FeatureAppContainer
+              featureAppId="testId"
+              featureAppDefinition={mockFeatureAppDefinition}
+            />
+          );
+
+          testRenderer.unmount();
+          await resolveLoadingPromise();
+
+          expect(consoleErrorSpy).not.toHaveBeenCalled();
+        });
+      });
     });
   });
 

diff --git a/packages/react/src/internal/internal-feature-app-container.tsx b/packages/react/src/internal/internal-feature-app-container.tsx
@@ -275,7 +275,9 @@ export class InternalFeatureAppContainer<
 
       featureApp.loadingPromise
         .then(() => {
-          this.setState({loading: false});
+          if (this.mounted) {
+            this.setState({loading: false});
+          }
         })
         .catch((loadingError) => {
           try {