Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PK chunking to other failure messages #76

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

dmosorast
Copy link
Contributor

Description of change

https://stitchdata.atlassian.net/browse/SRCE-2642

It seems that Bulk queries can fail with different messages than simply "timeout", this PR extends the functionality of PK Chunking to cover those situations.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Ran through a low-volume sync (no pk chunking_ to check for syntax errors. Did not test logic.

Risks

Medium-low, the original case is still handled, but this may not fix all extraneous cases.

Rollback steps

  • revert this branch

@dmosorast dmosorast merged commit 417cb2c into master Apr 1, 2020
@dmosorast dmosorast deleted the fix/pk-chunking-on-non-timeout-messages branch April 1, 2020 14:40
@dmosorast dmosorast mentioned this pull request Apr 1, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants