Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment cancellation confirmation feature no longer needed? #1521

Closed
sharkykh opened this issue Sep 11, 2018 · 2 comments
Closed

Comment cancellation confirmation feature no longer needed? #1521

sharkykh opened this issue Sep 11, 2018 · 2 comments

Comments

@sharkykh
Copy link
Contributor

sharkykh commented Sep 11, 2018

Hello,

Seems like GitHub has incorporated the add-confirmation-to-comment-cancellation.js feature natively.

As can be seen on this GIF, the alert is shown twice.
When I disable the feature in refined-github's extension settings, it's only shown once.

This may need more confirmation, because I'm not sure as to the full scope of the feature.

GIF

2018-09-11_21-39-02

@notlmn
Copy link
Contributor

notlmn commented Sep 11, 2018

@lukehefson Is this a feature that GH accidentally added while adding resolve conversation feature?

sindresorhus pushed a commit that referenced this issue Sep 14, 2018
@lukehefson
Copy link

lukehefson Is this a feature that GH accidentally added while adding resolve conversation feature?

@notlmn Nope. We shipped this purposefully as part of our Papercuts initiative. Apologies for not noticing the conflict here sooner! 😬

fregante added a commit to refined-github/github-url-detection that referenced this issue May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants