Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests and prop-types #1

Open
sindresorhus opened this issue Jan 12, 2018 · 3 comments
Open

Add more tests and prop-types #1

sindresorhus opened this issue Jan 12, 2018 · 3 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt help wanted Extra attention is needed

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Jan 12, 2018

Issuehunt badges

I didn't feel it was worth all the boilerplate and setup just for 4 super simple exports that I've manually tested well, but tests should be added when more things are added.

Should use AVA.

This task also includes adding prop types and default prop values to the types.

Inspiration: https://github.com/ReactTraining/react-router/tree/master/packages/react-router-dom/modules/__tests__

There is a $40.00 open bounty on this issue. Add more on Issuehunt.

@sindresorhus sindresorhus added the help wanted Extra attention is needed label Feb 1, 2018
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@kishan3
Copy link

kishan3 commented Mar 28, 2019

Hi, @sindresorhus Interested to contribute. Please let me know if any contribution guide is available.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@sindresorhus
Copy link
Owner Author

We have some tests now, but we could always use more! :)

@sindresorhus sindresorhus changed the title Tests Add more tests and prop-types Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants