Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot find name 'Element' #94

Closed
stephenplusplus opened this issue Oct 3, 2019 · 2 comments
Closed

Cannot find name 'Element' #94

stephenplusplus opened this issue Oct 3, 2019 · 2 comments

Comments

@stephenplusplus
Copy link

🤗🍰🍴

I think we got hit by something here in the last is release: googleapis/nodejs-pubsub#769
@stephenplusplus stephenplusplus changed the title Element Cannot find name Element' Oct 3, 2019
@stephenplusplus stephenplusplus changed the title Cannot find name Element' Cannot find name 'Element' Oct 3, 2019
@gioragutt
Copy link
Collaborator

gioragutt commented Oct 3, 2019 •
edited
Loading

I think it's related to #93.
Element is probably from the dom ts lib.

I wonder why this has not come up in the testing.

Edit: probably due to @types/jsdom in devDependencies.

@sindresorhus
Copy link
Owner

Ah, I missed that one. The Element type is really complex. Doesn't look like bundling the needed DOM types will be feasible... I have reverted it and done a new release: https://github.com/sindresorhus/is/releases/tag/v1.2.0

We'll have to wait for microsoft/TypeScript#33111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sindresorhus @stephenplusplus @gioragutt