Skip to content

Node v10 compatibility #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmcw opened this issue May 2, 2018 · 1 comment
Closed

Node v10 compatibility #25

tmcw opened this issue May 2, 2018 · 1 comment

Comments

@tmcw
Copy link

tmcw commented May 2, 2018

Hi Sindre!

The Node v10 compatibility issue in cpy leads up here, in cp-file.

The overview is:

  • Tests fail in cp-file on Node v10.0.0
  • This appears to be a result of cp-file's handling of readable streams, in that it waits a tick between when a stream becomes readable and when it starts reading from that stream
  • This results in the copy promise never resolving, and all copied files being 0 bytes

I've submitted a sketch of a PR: #24 that fixes this bug at the cost of creating directories even when the readable stream fails; would appreciate any guidance for how to achieve both goals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcw @sindresorhus