Unlocked the spin lock before closing the bdev.

sangramsimplyblock · sangramsimplyblock · commit a7ce4625d7be · 2025-01-29T10:40:15.000Z
diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c
@@ -9397,6 +9397,7 @@ bdev_set_qos_limit_done(struct set_qos_limit_ctx *ctx, int status)
 	char		*tmp_remove_bdev_names[255] = {NULL};
 	spdk_spin_lock(&ctx->bdev->internal.spinlock);
 	ctx->bdev->internal.qos_mod_in_progress = false;
+	spdk_spin_unlock(&ctx->bdev->internal.spinlock);
 	SPDK_NOTICELOG("Set qos limit done for %s\n", ctx->qos_bdev_node->bdev_name);
 	if(ctx->internal_request == true)
 	{
@@ -9477,7 +9478,6 @@ bdev_set_qos_limit_done(struct set_qos_limit_ctx *ctx, int status)
 		ctx->cb_fn(ctx->cb_arg,0);
 		free(ctx);
 	}
-	spdk_spin_unlock(&ctx->bdev->internal.spinlock);
 	return;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -9397,6 +9397,7 @@ bdev_set_qos_limit_done(struct set_qos_limit_ctx *ctx, int status)`
`9397`	`9397`	`char *tmp_remove_bdev_names[255] = {NULL};`
`9398`	`9398`	`spdk_spin_lock(&ctx->bdev->internal.spinlock);`
`9399`	`9399`	`ctx->bdev->internal.qos_mod_in_progress = false;`
	`9400`	`+ spdk_spin_unlock(&ctx->bdev->internal.spinlock);`
`9400`	`9401`	`SPDK_NOTICELOG("Set qos limit done for %s\n", ctx->qos_bdev_node->bdev_name);`
`9401`	`9402`	`if(ctx->internal_request == true)`
`9402`	`9403`	`{`
`@@ -9477,7 +9478,6 @@ bdev_set_qos_limit_done(struct set_qos_limit_ctx *ctx, int status)`
`9477`	`9478`	`ctx->cb_fn(ctx->cb_arg,0);`
`9478`	`9479`	`free(ctx);`
`9479`	`9480`	`}`
`9480`		`- spdk_spin_unlock(&ctx->bdev->internal.spinlock);`
`9481`	`9481`	`return;`
`9482`	`9482`	`}`
`9483`	`9483`