Skip to content

Commit e3d0eda

Browse files
committed
Added default values of private fields when not in developer mode
1 parent 8723ea1 commit e3d0eda

File tree

3 files changed

+68
-1
lines changed

3 files changed

+68
-1
lines changed

scripts/cli-wrapper.jinja2

+10
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,16 @@ class CLIWrapper(CLIWrapperBase):
104104
{%- if argument.dest is defined and argument.dest != argument.name %}
105105
args.{{ argument.dest }} = args.{{ argument.name }}
106106
{%- endif -%}
107+
{%- endfor %}
108+
{%- set ns = namespace(if_opened = False) %}
109+
{%- for parameter in subcommand.parameters -%}
110+
{%- if parameter.private is defined and parameter.private and parameter.default is defined %}
111+
{%- if not ns.if_opened %}
112+
if not self.developer_mode:
113+
{%- set ns.if_opened = True %}
114+
{%- endif %}
115+
args.{{ parameter.dest }} = {{ parameter | default_value }}
116+
{%- endif -%}
107117
{%- endfor -%}
108118
{%- if subcommand.private %}
109119
if not self.developer_mode:

simplyblock_cli/cli.py

+57
Original file line numberDiff line numberDiff line change
@@ -873,6 +873,14 @@ def run(self):
873873
elif sub_command in ['deploy-cleaner']:
874874
ret = self.storage_node__deploy_cleaner(sub_command, args)
875875
elif sub_command in ['add-node']:
876+
if not self.developer_mode:
877+
args.jm_percent = '3'
878+
args.number_of_distribs = 4
879+
args.small_bufsize = '0'
880+
args.large_bufsize = '0'
881+
args.enable_ha_jm = False
882+
args.ha_jm_count = '3'
883+
args.id_device_by_nqn = False
876884
ret = self.storage_node__add_node(sub_command, args)
877885
elif sub_command in ['delete']:
878886
ret = self.storage_node__delete(sub_command, args)
@@ -883,6 +891,12 @@ def run(self):
883891
elif sub_command in ['get']:
884892
ret = self.storage_node__get(sub_command, args)
885893
elif sub_command in ['restart']:
894+
if not self.developer_mode:
895+
args.max_snap = '0'
896+
args.max_prov = ''
897+
args.number_of_devices = '0'
898+
args.small_bufsize = '0'
899+
args.large_bufsize = '0'
886900
ret = self.storage_node__restart(sub_command, args)
887901
elif sub_command in ['shutdown']:
888902
ret = self.storage_node__shutdown(sub_command, args)
@@ -972,10 +986,50 @@ def run(self):
972986
elif args.command in ['cluster']:
973987
sub_command = args_dict['cluster']
974988
if sub_command in ['deploy']:
989+
if not self.developer_mode:
990+
args.ha_jm_count = '3'
991+
args.blk_size = '512'
992+
args.page_size = '2097152'
993+
args.grafana_endpoint = ''
994+
args.distr_bs = '4096'
995+
args.max_queue_size = '128'
996+
args.inflight_io_threshold = '4'
997+
args.jm_percent = '3'
998+
args.max_snap = '500'
999+
args.number_of_distribs = '4'
1000+
args.small_bufsize = '0'
1001+
args.large_bufsize = '0'
1002+
args.enable_ha_jm = False
1003+
args.lvol_name = 'lvol01'
1004+
args.lvol_size = '10G'
1005+
args.pool_name = 'pool01'
1006+
args.pool_max = '25G'
1007+
args.snapshot = False
1008+
args.max_size = '1000G'
1009+
args.encrypt = False
1010+
args.distr_vuid = '0'
1011+
args.lvol_ha_type = 'default'
1012+
args.fstype = 'xfs'
9751013
ret = self.cluster__deploy(sub_command, args)
9761014
elif sub_command in ['create']:
1015+
if not self.developer_mode:
1016+
args.page_size = '2097152'
1017+
args.distr_bs = '4096'
1018+
args.distr_chunk_bs = '4096'
1019+
args.ha_type = 'single'
1020+
args.max_queue_size = '128'
1021+
args.inflight_io_threshold = '4'
1022+
args.enable_qos = False
9771023
ret = self.cluster__create(sub_command, args)
9781024
elif sub_command in ['add']:
1025+
if not self.developer_mode:
1026+
args.page_size = '2097152'
1027+
args.distr_bs = '4096'
1028+
args.distr_chunk_bs = '4096'
1029+
args.ha_type = 'single'
1030+
args.max_queue_size = '128'
1031+
args.inflight_io_threshold = '4'
1032+
args.enable_qos = False
9791033
ret = self.cluster__add(sub_command, args)
9801034
elif sub_command in ['activate']:
9811035
ret = self.cluster__activate(sub_command, args)
@@ -1025,6 +1079,9 @@ def run(self):
10251079
elif args.command in ['volume', 'lvol']:
10261080
sub_command = args_dict['volume']
10271081
if sub_command in ['add']:
1082+
if not self.developer_mode:
1083+
args.distr_vuid = '0'
1084+
args.ha_type = 'default'
10281085
ret = self.volume__add(sub_command, args)
10291086
elif sub_command in ['qos-set']:
10301087
ret = self.volume__qos_set(sub_command, args)

simplyblock_core/env_var

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
SIMPLY_BLOCK_COMMAND_NAME=sbcli-dev
2-
SIMPLY_BLOCK_VERSION=14.0.11
2+
SIMPLY_BLOCK_VERSION=14.0.12
33

44
SIMPLY_BLOCK_DOCKER_IMAGE=public.ecr.aws/simply-block/simplyblock:main
55
DOCKER_USER=hamdysimplyblock

0 commit comments

Comments
 (0)