detach controller before attach remote devs

Author: hamdy-simplyblock

env_var

@@ -1,5 +1,5 @@
 SIMPLY_BLOCK_COMMAND_NAME=sbcli-dev
-SIMPLY_BLOCK_VERSION=4.0.15
+SIMPLY_BLOCK_VERSION=4.0.16
 
 
 SIMPLY_BLOCK_DOCKER_IMAGE=simplyblock/simplyblock:main-dev

simplyblock_core/cluster_ops.py

@@ -26,12 +26,6 @@
 
 
 def _create_update_user(cluster_id, grafana_url, grafana_secret, user_secret, update_secret=False):
-    if not grafana_url.startswith("https://"):
-        if grafana_url.startswith("http://"):
-            grafana_url = grafana_url.replace("http://", "https://", 1)
-        else:
-            grafana_url = "https://" + grafana_url
-
     session = requests.session()
     session.auth = ("admin", grafana_secret)
     headers = {

simplyblock_core/services/main_distr_event_collector.py

@@ -50,9 +50,9 @@ def process_device_event(event):
         if device.node_id != node_id:
             logger.info(f"Setting storage id: {storage_id} unavailable")
             distr_controller.send_dev_status_event(device, NVMeDevice.STATUS_UNAVAILABLE, node)
-            if device.status == NVMeDevice.STATUS_ONLINE:
-                device_controller.device_set_io_error(device_id, True)
-                device_controller.device_set_unavailable(device_id)
+            # if device.status == NVMeDevice.STATUS_ONLINE:
+            #     device_controller.device_set_io_error(device_id, True)
+            #     device_controller.device_set_unavailable(device_id)
 
         else:
             if node.status not in [StorageNode.STATUS_ONLINE, StorageNode.STATUS_SUSPENDED]:

simplyblock_core/storage_node_ops.py

@@ -829,7 +829,10 @@ def _connect_to_remote_jm_devs(this_node, jm_ids=[]):
             logger.debug(f"bdev found {bdev_name}")
             jm_dev.status = JMDevice.STATUS_ONLINE
         else:
-            logger.info(f"Connecting {this_node.get_id()} to {name}")
+
+            logger.info(f"Connecting {name} to {this_node.get_id()}")
+            ret = rpc_client.bdev_nvme_detach_controller(name)
+            time.sleep(1)
             ret = rpc_client.bdev_nvme_attach_controller_tcp(
                 name, jm_dev.nvmf_nqn, jm_dev.nvmf_ip, jm_dev.nvmf_port)
             if ret:
@@ -1704,8 +1707,11 @@ def restart_storage_node(
 
     if snode.enable_ha_jm:
         logger.info("Connecting to remote JMs")
+        snode.remote_jm_devices = []
         snode.remote_jm_devices = _connect_to_remote_jm_devs(snode)
 
+    snode.write_to_db(db_controller.kv_store)
+
     logger.info("Setting node status to Online")
     set_node_status(node_id, StorageNode.STATUS_ONLINE)