Skip to content

Commit 1d867db

Browse files
add new params to node add
1 parent af15b2b commit 1d867db

File tree

5 files changed

+20
-3
lines changed

5 files changed

+20
-3
lines changed

cli-reference.yaml

+14
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,20 @@ commands:
183183
default: false
184184
action: store_true
185185
private: true
186+
- name: "--spdk-mem"
187+
help: "Set spdk hugepage size limitation"
188+
dest: spdk_mem
189+
required: false
190+
type: str
191+
default: ""
192+
- name: "--ssd-pcie"
193+
help: "Nvme PCIe address to use for storage device. Can be more than one."
194+
dest: ssd_pcie
195+
required: false
196+
type: str
197+
nargs: +
198+
default: ""
199+
186200
- name: delete
187201
help: "Deletes a storage node object from the state database."
188202
usage: >

scripts/cli-wrapper-gen.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def default_value(item):
7575

7676

7777
def split_value_range(value):
78-
return re.sub("\.\.", ', ', value)
78+
return re.sub("\\.\\.", ', ', value)
7979

8080

8181
def arg_value(item):

scripts/generate.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22

33
PYTHON="$(command -v python)"
44
if [[ "${PYTHON}" == "" ]]; then
5-
PYTHON="$(comamnd -v python3)"
5+
PYTHON="$(command -v python3)"
66
fi
77

8+
${PYTHON} -m pip install jinja2 PyYAML
89
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
910
${PYTHON} "${SCRIPT_DIR}/cli-wrapper-gen.py" "${SCRIPT_DIR}/.."

simplyblock_cli/cli.py

+2
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,8 @@ def init_storage_node__add_node(self, subparser):
108108
argument = subcommand.add_argument('--namespace', help='Kubernetes namespace to deploy on', type=str, dest='namespace', required=True)
109109
if self.developer_mode:
110110
argument = subcommand.add_argument('--id-device-by-nqn', help='Use device nqn to identify it instead of serial number', dest='id_device_by_nqn', required=False, action='store_true')
111+
argument = subcommand.add_argument('--spdk-mem', help='Set spdk hugepage size limitation', type=str, default='', dest='spdk_mem', required=False)
112+
argument = subcommand.add_argument('--ssd-pcie', help='Nvme PCIe address to use for storage device. Can be more than one.', type=str, default='', dest='ssd_pcie', required=False, nargs='+')
111113

112114
def init_storage_node__delete(self, subparser):
113115
subcommand = self.add_sub_command(subparser, 'delete', 'Deletes a storage node object from the state database.')

simplyblock_core/env_var

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
SIMPLY_BLOCK_COMMAND_NAME=sbcli-msn
2-
SIMPLY_BLOCK_VERSION=0.3.2
2+
SIMPLY_BLOCK_VERSION=0.3.3
33

44
SIMPLY_BLOCK_DOCKER_IMAGE=public.ecr.aws/simply-block/simplyblock:multi-snode
55
DOCKER_USER=hamdysimplyblock

0 commit comments

Comments
 (0)