Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to enter color name in color input field #134

Closed
bjarnef opened this issue Aug 8, 2019 · 1 comment
Closed

Allow to enter color name in color input field #134

bjarnef opened this issue Aug 8, 2019 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@bjarnef
Copy link

bjarnef commented Aug 8, 2019

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

When enter a color name like red or green in input field no matter of the current selected mode, it seems to shortly convert to the hexa code for red, but then revert to orginal selected color hexa code. In the preview the round circle has however been updated.

If the current behavior is a bug, please provide the steps to reproduce and create a JSFiddle.

https://jsfiddle.net/Simonwep/qx2Lod6r/
Can be reproduced in the default template or the demo page.
https://simonwep.github.io/pickr/

What is the expected behavior?

By enter e.g. red it is great if change to the hexa color code for red and update the preview as well. However it shouldn't revert back to original selected color code.
It also seems it is flickering a bit when just deleting part of the hexa code.

Your environment:

Version (see Pickr.version): 1.2.6
Used bundle (es5 or normal one): Normal
Used theme (default is classic): Classic
Browser-version:  Google Chrome Version 76.0.3809.100
Operating-system:  Windows 10

2019-08-08_14-32-49

Off topic: There is a minor typoe here https://github.com/Simonwep/pickr#the-hsvacolor-object should be "Converts the object to a cmyk array" instead of "Converts the object to a cymk array".

@simonwep simonwep added the duplicate This issue or pull request already exists label Aug 8, 2019
@simonwep
Copy link
Owner

simonwep commented Aug 8, 2019

Kinda a duplicate of #133, anyway fixed in 973f317 :) It will now convert the color-name to the current representation if the input field get's blurred! Ah yeah, thank's - fixed the typo ^^

@simonwep simonwep closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants