Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to apply sort on mobile in portrait mode #199

Closed
simonw opened this issue Apr 9, 2018 · 4 comments
Closed

Ability to apply sort on mobile in portrait mode #199

simonw opened this issue Apr 9, 2018 · 4 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Apr 9, 2018

Missed this in #189... on mobile in portrait mode we hide the column headers, which means you can't click them to sort! You can sort in landscape mode at least.

Need to come up with an alternative sort UI for portrait on mobile.

@simonw simonw added the small label Apr 9, 2018
@simonw
Copy link
Owner Author

simonw commented Apr 9, 2018

I may do this by adding select boxes for _sort and _sort_desc to the filters UI. This would allow sorting in mobile portrait mode but would also ensure that the existing sort order is persisted if the user edits the current filters (right now sort resets when filters are applied).

@simonw
Copy link
Owner Author

simonw commented Apr 9, 2018

Since you can't apply _sort and _sort_desc at the same time, maybe just one select box for picking the column to sort by and a boolean checkbox for "sort descending" - which then redirects to the _sort_desc= URL variant.

@simonw
Copy link
Owner Author

simonw commented Apr 10, 2018

2018-04-09 at 5 32 pm

@simonw simonw closed this as completed in 57b19f0 Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant