Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit left/right styles not adapted for RTL UI #3604

Open
imnasnainaec opened this issue Feb 5, 2025 · 1 comment
Open

Explicit left/right styles not adapted for RTL UI #3604

imnasnainaec opened this issue Feb 5, 2025 · 1 comment
Assignees
@imnasnainaec
Labels
bug Something isn't working font/language frontend

Comments

@imnasnainaec
Copy link
Collaborator

In our React code, there are a few dozen instances of explicitly defined left, right, marginLeft, marginRight, paddingLeft, paddingRight, and borderLeft which don't reverse when the UI language is switched to Arabic, a right-to-left (RTL) language.

We can use (e.g.) style={(document.body.dir === "rtl" ? { left: 0 } : { right: 0 }}, but it would be better to implement more global theme/style solutions.
@imnasnainaec imnasnainaec added bug Something isn't working font/language frontend labels Feb 5, 2025
@imnasnainaec imnasnainaec self-assigned this Feb 6, 2025
@imnasnainaec
Copy link
Collaborator Author

Is this actually an issue? Are there places we've manually switched it that we shouldn't have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imnasnainaec imnasnainaec

Labels
bug Something isn't working font/language frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imnasnainaec