Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS and MAX_REQUEST_DATA_COLUMN_SIDECARS for data columns #6240

Open
jimmygchen opened this issue Aug 7, 2024 · 0 comments
Open

Use MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS and MAX_REQUEST_DATA_COLUMN_SIDECARS for data columns #6240

jimmygchen opened this issue Aug 7, 2024 · 0 comments
Labels
bug Something isn't working das Data Availability Sampling fulu Required for the upcoming Fulu hard fork

Comments

@jimmygchen
Copy link
Member

jimmygchen commented Aug 7, 2024 •
edited
Loading

Description

The current das branch incorrectly re-used the Deenb MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS for data column sidecars.

  • There's a new config value for this, MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS, which should be used instead. This should be configurable at run time (config value).
  • Also added MAX_REQUEST_DATA_COLUMN_SIDECARS

Spec: https://github.com/ethereum/consensus-specs/blob/8f8ab03acf1656c54f3a81ef18878f853a1cc4c6/specs/_features/eip7594/p2p-interface.md#configuration
@jimmygchen jimmygchen added bug Something isn't working das Data Availability Sampling labels Aug 7, 2024
@jimmygchen jimmygchen mentioned this issue Aug 22, 2024
Merged
@jimmygchen jimmygchen changed the title Use MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS for data columns Use MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS and MAX_REQUEST_DATA_COLUMN_SIDECARS for data columns Jan 24, 2025
@jimmygchen jimmygchen added the fulu Required for the upcoming Fulu hard fork label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working das Data Availability Sampling fulu Required for the upcoming Fulu hard fork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimmygchen