Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tree-states works with linear_blocks=false #4484

Open
michaelsproul opened this issue Jul 7, 2023 · 0 comments
Open

Ensure tree-states works with linear_blocks=false #4484

michaelsproul opened this issue Jul 7, 2023 · 0 comments
Labels
database tree-states Upcoming state and database overhaul

Comments

@michaelsproul
Copy link
Member

Description

Tree states introduces a new format for storing finalized blocks on disk, which we're planning to make optional via the linear_blocks store config option:

  • linear_blocks=false (unstable today): blocks are all stored in the hot DB keyed by root
  • linear_blocks=true (tree-states today): finalized blocks are stored compressed in the freezer DB keyed by slot

This issue is about ensuring that Lighthouse can function correctly in tree-states mode with linear_blocks=false. At the moment the configuration option exists, but tree-states ignores it and just assumes blocks are in the freezer DB. We need to ensure that functions like get_blinded_block look-up the correct location.

It may be easier to implement and test this at the same time as the database migration (#4482). Alternatively we could ensure that starting a tree-states node with linear_blocks=false behaves correctly.

For the initial version I don't think we need a way to switch the linear_blocks setting of an existing DB. Users can re-sync if they really want the benefit of that, or we can add such a method later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database tree-states Upcoming state and database overhaul
Projects
None yet
Development

No branches or pull requests

1 participant