Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore runtime configurable EthSpec #4376

Closed
realbigsean opened this issue Jun 5, 2023 · 2 comments
Closed

Restore runtime configurable EthSpec #4376

realbigsean opened this issue Jun 5, 2023 · 2 comments
Assignees
Labels

Comments

@realbigsean
Copy link
Member

Description

In a bunch of tests we set the EthSpec at runtime, and this is no longer possible because FIELD_ELEMENTS_PER_BLOB is required at compile time in the c-kzg lib. Michael's raised an issue here for how to resolve it: ethereum/c-kzg-4844#312

When it's resolved, we have some spec-minimal vs spec-mainnet feature gating in tests that we will be able to remove.

@realbigsean
Copy link
Member Author

Since ethereum/c-kzg-4844#312 was merged, we're now in a place where we can work out this:

When it's resolved, we have some spec-minimal vs spec-mainnet feature gating in tests that we will be able to remove.

I can pick up this part because I have a pretty good idea of where we did this type of feature gating. So I'm gonna re-assign this issue to me. Thanks for figuring this out michael! This was a massive pain point.

@realbigsean
Copy link
Member Author

resolved in #4468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants