Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of serde_utils #2617

Closed
michaelsproul opened this issue Sep 23, 2021 · 1 comment
Closed

Remove duplication of serde_utils #2617

michaelsproul opened this issue Sep 23, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@michaelsproul
Copy link
Member

Description

We currently have two copies of the quoted_u64 serde utils in:

  1. consensus/serde_utils and
  2. consensus/ssz_types/serde_utils

The duplication was seemingly introduced in #1794 to avoid a circular dependency, but I'm not seeing one. It seems like ssz_types could depend on serde_utils and that would be fine (serde_utils doesn't depend on ssz_types, even transitively).
@michaelsproul michaelsproul added the good first issue Good for newcomers label Sep 23, 2021
@michaelsproul
Copy link
Member Author

Nevermind, I didn't notice that the impls in ssz_types are specialised to FixedVector and VariableList. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul