Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels and service entry #741

Closed
mr-miles opened this issue Apr 18, 2023 · 1 comment
Closed

Add labels and service entry #741

mr-miles opened this issue Apr 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mr-miles
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I have a process running on each node and I want it to send requests to the node-local agent trace endpoints. I don't have any way to configure it on a node-specific basis - it can only be configured via config file and that has to be the same everywhere.

I planned to do this by defining a service that points to the pods in the daemonset and has a local InternalTrafficPolicy. This would mean traffic always targetted the node-local endpoints.

It works very well but I found the pods in the daemonset are missing a label to enable them to be targetted by a selector.

Describe the solution you'd like

I made a PR that adds the component label and also an option to the chart that sets up a service entry as described.
#740

Describe alternatives you've considered

No response

Additional context

No response

@mr-miles mr-miles added the enhancement New feature or request label Apr 18, 2023
@github-actions github-actions bot added the Stale label Oct 10, 2023
@signalfx signalfx deleted a comment from github-actions bot Oct 10, 2023
@atoulme atoulme removed the Stale label Oct 10, 2023
@atoulme
Copy link
Contributor

atoulme commented Oct 10, 2023

Thank you for your contribution! Closing this issue as complete.

@atoulme atoulme closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants