Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extra/custom annotations in secret-validation-hook #349

Closed
akorp opened this issue Jan 10, 2022 · 0 comments · Fixed by #350
Closed

Add support for extra/custom annotations in secret-validation-hook #349

akorp opened this issue Jan 10, 2022 · 0 comments · Fixed by #350

Comments

@akorp
Copy link
Contributor

akorp commented Jan 10, 2022

Add support for extra/custom annotations for secret-validation-hook (pod splunk-otel-collector-validate-secret) to control sidecar containers.

In our kubernetes cluster linkerd injects sidecar containers to all pods, except those with annotation linkerd.io/inject: disabled.
Since we don't have an option to add annotation for secret-validation-hook, pod splunk-otel-collector-validate-secret is getting into NotReady state - container validate-secret is successfully completed with exit code 0, but linkerd sidecar container linkerd-proxy keeps running. This blocks the helm release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant