Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc/video call support #1046

Closed
1 task done
Trolldemorted opened this issue Feb 3, 2017 · 12 comments
Closed
1 task done

webrtc/video call support #1046

Trolldemorted opened this issue Feb 3, 2017 · 12 comments

Comments

@Trolldemorted
Copy link
Contributor

  • I have searched open and closed issues for duplicates

Will Signal-Desktop get WebRTC support?

@wlritchi
Copy link

wlritchi commented Feb 8, 2017

Is this related to #554 or are you thinking for some other reason?

@Trolldemorted
Copy link
Contributor Author

Webrtc should be way more easy to implement than redphone, since chrome should already support it.

@mstargard
Copy link

Not to poo poo the idea, but what about the issue with WebRTC unmasking vpn users? Is that still a concern? https://torrentfreak.com/huge-security-flaw-leaks-vpn-users-real-ip-addresses-150130/

@Trolldemorted
Copy link
Contributor Author

Is this threat model relevant for Signal-Desktop? I trust Signal-Desktop to not snoop my IP and send it anywhere, and websites may exploit it no matter what signal does.

@mstargard
Copy link

That's a good question. I was thinking more along the lines that privacy-conscious people will disable WebRTC in their browser because they use a VPN, thus making it unavailable for Signal. Or, perhaps the converse is more important: That if Signal uses WebRTC, will a user be outed because of it?

@strugee
Copy link
Contributor

strugee commented Mar 11, 2017

WebRTC works by establishing a direct peer-to-peer connection. This is efficient because it provides the shortest/most direct (and thus fastest) path through the network. For this reason both parties need to know the other's IP address, because they're connecting directly to each other.

The way that the Android client handles this is by providing an option to route WebRTC calls through the Signal server. This is less performant because it takes a less direct network path but allows you to avoid leaking your IP address to the person you're calling.

Also, @Trolldemorted, you should edit your title to include the keyword "video call" so this shows up in searches.

@Trolldemorted Trolldemorted changed the title webrtc support webrtc/video call support Mar 11, 2017
@zero77
Copy link

zero77 commented Nov 19, 2017

What was the reason for webrtc being chosen over SIP.

@nrizzio
Copy link
Contributor

nrizzio commented Nov 19, 2017

@zero77 this isn't the discussion forum, go to https://whispersystems.discoursehosting.net instead

@thecyberd3m0n
Copy link

I think Redphone procotol could be also implemented in Electron version of Signal. Is it an option to not change current protocol but use existing?

@strugee
Copy link
Contributor

strugee commented Mar 5, 2018

@thecyberd3m0n I'm not sure what you mean. Signal on mobile already uses WebRTC for both audio and video, as of (IIRC) March 2017. The "Redphone protocol" is old and not used anymore, at least AFAIK.

@thecyberd3m0n
Copy link

I'm sorry, I've got outdated information

@mrj0b
Copy link

mrj0b commented Apr 18, 2018

any news or updates on when this feature will be implemented

@signalapp signalapp locked and limited conversation to collaborators Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

10 participants