fix: Add UNITY_EDITOR preprocessor directives to editor scripts #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is due to the misconfiguration of the assembly definition at the com.siemens.ros-sharp/Editor/siemens.ros-sharp.Editor.asmdef file. It's marked as Note, that it's not conventional to surround Editor-only (the ones having
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portions of code with Editor code were being compiled into the Android APK, which caused compilation errors.
I deactivated that portion of the code using the preprocessor directive
#if UNITY_EDITOR.I also replaced two deprecation warnings in
com.siemens.ros-sharp/Editor/RosBridgeClient/RosConnectorEditor.cs.This fixes #478. It may be related to #475, which seems to offer a simpler solution.