Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of errors and reconciliation #27

Closed
rsmitty opened this issue Aug 14, 2020 · 0 comments
Closed

Better handling of errors and reconciliation #27

rsmitty opened this issue Aug 14, 2020 · 0 comments

Comments

@rsmitty
Copy link
Member

rsmitty commented Aug 14, 2020

We don't need to return the errors that get encountered in capi providers. Instead, we should just log the error, and return ctrl.Result{}, nil. If the resource status is not ready, a redo of the reconcile gets triggered anyways. This exists in all of our providers, so we'll need to clean it up everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants