Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest patch release seems to contain a breaking change #54

Closed
jplatte opened this issue Oct 4, 2024 · 4 comments
Closed

Latest patch release seems to contain a breaking change #54

jplatte opened this issue Oct 4, 2024 · 4 comments

Comments

@jplatte
Copy link

jplatte commented Oct 4, 2024

sqlformat::format now requires a &FormatOptions<_> for its third argument, when it used to take an owned FormatOptions. This makes SQLx fail to compile with that version.

Please consider yanking v0.2.7.

@abonander
Copy link

cc launchbadge/sqlx#3544

@shssoichiro
Copy link
Owner

The version has been yanked. I'd like to avoid this in the future. Are there any suggestions for catching this early? I recall there being a cargo tool to semi-automate this, though I can't remember what it was called.

@jplatte
Copy link
Author

jplatte commented Oct 5, 2024

You're probably thinking of https://github.com/obi1kenobi/cargo-semver-checks

@shssoichiro
Copy link
Owner

It looks like the breaking change is difficult to isolate and revert without reverting meaningful changes. As such, I'm moving forward releasing the new version as 0.3.0 instead so that it is properly acknowledged as breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants